| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix lack of message pluralization |
| Date: | 2026-09-03 11:29:23 |
| Message-ID: | BDA7E255-6E17-4F6E-AD88-0363BF2623F3@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
> On 3 Sep 2026, at 12:47, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> Fix lack of message pluralization
Maybe I'm daft, but why is the message below pluralized since the %d parameter
is the same?
--- a/src/backend/commands/trigger.c
+++ b/src/backend/commands/trigger.c
@@ -904,8 +904,10 @@ CreateTriggerFiringOn(const CreateTrigStmt *stmt, const char *queryString,
if (nargs > PG_INT16_MAX)
ereport(ERROR,
errcode(ERRCODE_TOO_MANY_ARGUMENTS),
- errmsg("triggers cannot have more than %d arguments",
- PG_INT16_MAX));
+ errmsg_plural("triggers cannot have more than %d argument",
+ "triggers cannot have more than %d arguments",
+ PG_INT16_MAX,
+ PG_INT16_MAX));
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-09-03 12:49:19 | Re: pgsql: Fix lack of message pluralization |
| Previous Message | Peter Eisentraut | 2026-09-03 10:47:18 | pgsql: Fix lack of message pluralization |