| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Florian Pflug <fgp(at)phlo(dot)org>, Radosław Smogura <rsmogura(at)softperience(dot)eu>, Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | Re: Patch Review: Bugfix for XPATH() if text or attribute nodes are selected |
| Date: | 2011-07-10 22:06:22 |
| Message-ID: | BC66B446-29EC-44FA-8860-7165F5105BDA@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Jul 10, 2011, at 1:40 PM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> Hackers,
>
>>> B. 6. Current behaviour _is intended_ (there is "if" to check node type) and _"natural"_. In this particular case user ask for text content of some node, and this content is actually "<".
>>
>> I don't buy that. The check for the node type is there because
>> two different libxml functions are used to convert nodes to
>> strings. The if has absolutely *zero* to do with escaping, expect
>> for that missing escape_xml() call in the "else" case.
>>
>> Secondly, there is little point in having an type XML if we
>> don't actually ensure that values of that type can only contain
>> well-formed XML.
>
> Can anyone else weigh in on this? Peter?
Unless I am missing something, Florian is clearly correct here.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2011-07-10 22:23:04 | Re: Kaigai's current patches -- review, commit status |
| Previous Message | Jeff Davis | 2011-07-10 21:15:55 | Re: reducing the overhead of frequent table locks, v4 |