| From: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
|---|---|
| To: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, "Schneider (AWS), Jeremy" <schnjere(at)amazon(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Query Jumbling for CALL and SET utility statements |
| Date: | 2022-09-01 15:13:42 |
| Message-ID: | BBB9A13D-BBE2-44A4-9CA7-6E189120E5A2@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Please find attached v2 as an attempt to do so.
+1 to the idea.
I think it will be better to evaluate jstate instead of
JUMBLE_UTILITY, such as:
if (query->utilityStmt && !jstate)
instead of
if (query->utilityStmt && !JUMBLE_UTILITY(query->utilityStmt))
This will allow for support of potentially other utility statements
In the future without having to teach pg_stat_statements about them.
If a jstate is set for the utility statements, pgss will do the right thing.
Thanks
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jehan-Guillaume de Rorthais | 2022-09-01 16:41:56 | [BUG] wrong FK constraint name when colliding name on ATTACH |
| Previous Message | Junwang Zhao | 2022-09-01 14:38:41 | Re: [PATCH v1] fix potential memory leak in untransformRelOptions |