Re: This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.

Dear Michael, Inoue
Thanks very much.Postgres process still crash after solution2(symbols_conflict.patch) applied. So the other solution(solution1(20141029_pgodbc_rename_check_encoding.patch)) was perfered.Right?
regards,developer rohto
From: rohtodeveloper(at)outlook(dot)com
To: michael(dot)paquier(at)gmail(dot)com
CC: inoue(at)tpf(dot)co(dot)jp; pgsql-odbc(at)postgresql(dot)org
Subject: RE: [ODBC] This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.
Date: Thu, 13 Nov 2014 07:09:50 +0000

I think the solution2(symbols_conflict.patch) may not be able to solve the problem。 The solution2 is trying to make the odbc’s check_client_encoding() function into a local function. However, the postgres's check_client_encoding() function is still a global function. When the odbc driver is trying to call the check_client_encoding() function, while the postgres's check_client_encoding() function is still being exposed , the postgres's check_client_encoding() may still have a chance to be called by the odbc driver ,and cause the postgres process to crash.
Date: Mon, 3 Nov 2014 15:52:06 +0900
Subject: Re: Re: [ODBC] This may be a bug: odbc's function"check_client_encoding" have the same name with postgres's function.
From: michael(dot)paquier(at)gmail(dot)com
To: rohtodeveloper(at)outlook(dot)com
CC: inoue(at)tpf(dot)co(dot)jp; pgsql-odbc(at)postgresql(dot)org

On Mon, Nov 3, 2014 at 3:26 PM, developer rohto <rohtodeveloper(at)outlook(dot)com> wrote:
Thanks very much.

We decide to use your solution1(20141029_pgodbc_rename_check_encoding.patch).

On the other hand, by the way, which solution does the community prefer to choose?
The potential solution by Inoue-san to reduce dependencies between library objects is better.
--
Michael