Re: Re: [COMMITTERS] pgsql: Support comments on FOREIGN DATA WRAPPER and SERVER objects.

On Tue, Apr 5, 2011 at 6:03 AM, Shigeru HANADA
<hanada(at)metrosystems(dot)co(dot)jp> wrote:
> On Tue, 05 Apr 2011 13:37:48 +0900
> Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> wrote:
>> On Mon, 4 Apr 2011 12:47:18 -0400
>> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> > BTW, I think you can merge patches 0001 to 0004 into a single patch.
>>
>> They were separated just for review, so I'll post revised and unified
>> patch ASAP.
>
> Please find attached revised comment-on-user-mapping patches.
>
> * The comment_user_mapping_core.patch includes syntax support, catalog
> manipulation, pg_dump support, documents and regression tests.

I don't think it's going to fly to add a function
pg_usermapping_ownercheck() with a randomly different API than all the
parallel functions for other object types. There is probably some
more refactoring that needs to be done here to make this sane, but I'm
coming around to the view that trying to slip this into 9.1 is not the
best thing for us to be spending time on, especially considering that
it doesn't seem to be straightforward to figure out how it should
actually work. I am inclined to punt this to 9.2.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company