| From: | Marko Kreen <markokr(at)gmail(dot)com> |
|---|---|
| To: | Radosław Smogura <rsmogura(at)softperience(dot)eu> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: MMAP Buffers |
| Date: | 2011-04-16 19:41:19 |
| Message-ID: | BANLkTinv387tqTSc=x-CfiR1Y-SbdGn8dg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 15, 2011 at 3:12 PM, Radosław Smogura
<rsmogura(at)softperience(dot)eu> wrote:
> On Fri, 15 Apr 2011 14:33:37 +0300, Heikki Linnakangas wrote:
>> The patch is quite hard to read because of random whitespace changes
>> and other stylistic issues, but I have a couple of high-level
>> questions on the design:
>
> Yes, but, hmm... in Netbeans I had really long gaps (probably 8 spaces, from
> tabs), so deeper "ifs", comments at the and of variables, went of out my
> screen. I really wanted to not format this, but sometimes I needed.
Seems no one else has mentioned it yet -- Postgres uses non-standard
tab-width of 4, instead of 8. If you see ugly code in Postgres, thats why...
--
marko
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-16 22:23:24 | ALTER TABLE INHERIT vs collations |
| Previous Message | Greg Smith | 2011-04-16 19:19:53 | Re: Formatting Curmudgeons WAS: MMAP Buffers |