Re: pgAdmin III commit: Handle hostaddr connection parameter

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin III commit: Handle hostaddr connection parameter
Date: 2011-04-12 15:36:04
Message-ID: BANLkTincyF3=cjTj6fZqO5BgEeQ14qrR5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

I'm not happy with the way this is done (from the UI perspective). We
now have two fields on the server dialogue, one labelled "Host" and
one labelled "Host Address". It's not at all obvious to the user when
one should be used over the other.

To avoid confusion, I think we should put the Host Address field on
the Advanced Tab.

Also, I notice the documentation hasn't been updated for this, or any
of the other recent additions of controls to this dialogue. Can you
fix that please (the text at least - we can do the screenshots in one
go later)?

On Mon, Apr 11, 2011 at 6:11 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Handle hostaddr connection parameter
>
> Implements ticket #312.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=263ca64ec4579d69615a983517f1e93ca6c59a76
>
> Modified Files
> --------------
> CHANGELOG                           |    1 +
> pgadmin/db/pgConn.cpp               |   10 ++++++++--
> pgadmin/dlg/dlgSelectConnection.cpp |    4 ++--
> pgadmin/dlg/dlgServer.cpp           |    9 ++++++++-
> pgadmin/frm/frmMain.cpp             |    1 +
> pgadmin/frm/frmStatus.cpp           |    6 ++++--
> pgadmin/include/db/pgConn.h         |    8 ++++++--
> pgadmin/include/schema/pgServer.h   |   12 ++++++++++--
> pgadmin/pgscript/pgsApplication.cpp |    2 +-
> pgadmin/schema/pgRole.cpp           |    1 +
> pgadmin/schema/pgServer.cpp         |   21 ++++++++++++---------
> pgadmin/ui/dlgServer.xrc            |   14 +++++++++++++-
> 12 files changed, 67 insertions(+), 22 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Vladimir Kokovic 2011-04-12 18:19:08 Re: Copy/Paste table(s) functions
Previous Message Guillaume Lelarge 2011-04-12 08:10:22 Re: strings fixes