From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Shigeru Hanada <hanada(at)metrosystems(dot)co(dot)jp> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Foreign table permissions and cloning |
Date: | 2011-05-13 19:52:40 |
Message-ID: | BANLkTinS0Z4zAGgkNiTO0EgbKW7hMr9kJA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2011/5/11 Shigeru Hanada <hanada(at)metrosystems(dot)co(dot)jp>:
> (2011/04/26 5:42), Robert Haas wrote:
>> OK. Turned out a little more cleanup was needed to make this all the
>> way consistent with how we handle views; I have now done that.
>
> I noticed that some fixes would be needed for consistency about foreign
> table privileges. Attached patch includes fixes below:
>
> 1) psql doesn't complete FOREIGN TABLE after GRANT/REVOKE.
> 2) pg_dump uses GRANT .. ON TABLE for foreign tables, instead of ON
> FOREIGN TABLE.
> 3) GRANT document mentions that ALL TABLES includes foreign tables too.
> 4) Rows of information_schema.foreign_tables/foreign_table_options are
> visible to users who have any privileges on the foreign table.
Thanks; I'm embarrassed I didn't notice those things myself. I've
committed this patch with very slight adjustment.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2011-05-13 20:16:13 | Reducing overhead of frequent table locks |
Previous Message | Merlin Moncure | 2011-05-13 19:48:36 | hint bit cache v6 |