| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: perltidy |
| Date: | 2011-06-14 19:49:32 |
| Message-ID: | BANLkTinOi3kLPxfxnWgGY3-Na1-aicFF4g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 14, 2011 at 21:39, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Peter Eisentraut wrote:
>> How much do we care about applying perltidy, as described in
>> src/tools/msvc/README, everywhere? I just ran it across the entire
>> tree, using
>>
>> perltidy -b -bl -nsfs -naws -l=100 -ole=unix **/*.pl **/*.pm
>>
>> and it generated 6531 lines of (unified) diff, of which 357 are in
>> src/tools/msvc/ itself. So clearly it's not being applied very
>> consistently.
>>
>> Given how easily this appears to work and how we're sneakily expanding
>> the use of Perl, I think we ought to add this to the standard pgindent
>> routine.
>
> Yes, I would support that.
I think I suggested that before at some point, but can't find the
reference. But that means, +1.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2011-06-14 19:56:56 | Re: pgbench cpu overhead (was Re: lazy vxid locks, v1) |
| Previous Message | Bruce Momjian | 2011-06-14 19:39:04 | Re: perltidy |