Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tim Uckun <timuckun(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Date: 2011-05-24 03:10:13
Message-ID: BANLkTimfxAY+HSu8Wz_GBDQBi6Makyt21w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, May 23, 2011 at 2:57 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Robert Haas wrote:
>> On Mon, May 23, 2011 at 8:26 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> > Sorry, I was unclear. ?The question is whether the case of _name_ of the
>> > locale is significant, meaning can you have two locale names that differ
>> > only by case and behave differently?
>>
>> That would seem surprising to me, but I really have no idea.
>>
>> There's the other direction, too: two locales that vary by something
>> more than case, but still have identical behavior.  Maybe we just
>> decide not to worry about that, but then why worry about this?
>
> Well, if we remove the check then people could easily get broken
> upgrades by upgrading to a server with a different locale.  A Google
> search seems to indicate the locale names are case-sensitive so I am
> thinking the problem is that the user didn't have exact locales, and
> needs that to use pg_upgrade.

I think you misread what I wrote, or I misexplained it, but never
mind. Matching locale names case-insensitively sounds reasonable to
me, unless someone has reason to believe it will blow up.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message jose soares 2011-05-24 07:14:33 BUG #6036: why a REAL should be queried as a string?
Previous Message Greg Sabino Mullane 2011-05-24 02:08:46 Re: 9.1 plperlu bug with null rows in trigger hash

Browse pgsql-hackers by date

  From Date Subject
Next Message panam 2011-05-24 04:14:24 Hash Anti Join performance degradation
Previous Message Robert Haas 2011-05-24 03:08:40 Re: Pull up aggregate subquery