| From: | Alex Hunsaker <badalex(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix for Perl 5.14 |
| Date: | 2011-04-23 16:12:25 |
| Message-ID: | BANLkTima_E+xqO7b2vViWpmb1W759pb6Gg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 23, 2011 at 07:00, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 04/23/2011 03:02 AM, Alex Hunsaker wrote:
>> ...
>> There is a minor compile time error due to the API changing a bit:
>> plperl.c:929:3: error: lvalue required as left operand of assignment
>> ...
>> Unfortunately that macro is not available on older perls so the
>> attached provides our own macro when GvCV_set is not defined.
> How nice of them not to fix it in ppport.h. I thought this is exactly the
> sort of thing it's for.
Hrm, I have the latest released version of Devel::PPPort, 3.19. I went
poking around and found the have a newer "developer" release (3.19_03)
at http://search.cpan.org/~mhx/Devel-PPPort-3.19_03/ (released
2011-04-13). I see a few things for 5.14 but nothing about GvCV_set.
Maybe I'm doing something wrong? I'm just diffing its ppport.h with
ours. For the curious its attached.
> This looks OK, but I think we need to wait until they remove the RC tag.
Makes sense, Ill repost once they do ;).
| Attachment | Content-Type | Size |
|---|---|---|
| ppport.patch.gz | application/x-gzip | 11.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-23 17:17:14 | Some TODO items for collations |
| Previous Message | Kevin Grittner | 2011-04-23 15:52:27 | Re: What Index Access Method Functions are really needed? |