From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WALInsertLock tuning |
Date: | 2011-06-08 02:18:05 |
Message-ID: | BANLkTiknRC4e6YCbSO+XzMGy++gG+6KiMQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 7, 2011 at 9:54 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Tue, Jun 7, 2011 at 1:24 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> One other thought is that I think that this patch might cause a
>> user-visible behavior change. Right now, when you hit the end of
>> recovery, you most typically get a message saying - record with zero
>> length. Not always, but often. If we adopt this approach, you'll get
>> a wider variety of error messages there, depending on exactly how the
>> new record fails validation. I dunno if that's important to be worth
>> caring about, or not.
>
> Not.
>
> We've never said what the message would be, only that it would fail.
BTW, walreceiver doesn't zero the page before writing the WAL. So,
if zeroing the page is *really* required for safe recovery, we might need
to change walreceiver.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Dan Ports | 2011-06-08 03:02:26 | Re: reindex creates predicate lock on index root |
Previous Message | Robert Haas | 2011-06-08 02:17:49 | Re: BUG #6041: Unlogged table was created bad in slave node |