Re: pass in array to function for use by where clause? how optimize?

From: Anish Kejariwal <anishkej(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Rob Sargent <robjsargent(at)gmail(dot)com>, pgsql-sql(at)postgresql(dot)org
Subject: Re: pass in array to function for use by where clause? how optimize?
Date: 2011-04-13 19:03:51
Message-ID: BANLkTikaMxuLMV+q2vFGWQ59SU1VO5VkLA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-sql

Thanks Tom! I've never used the any function before. It totally fixed the
issue. It's easier to code, makes more sense, and it fixed my performance
issue.

My guess is that the optimizer does not how to deal with
generate_subscripts??

Thanks!!

Anish

On Wed, Apr 13, 2011 at 9:15 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Rob Sargent <robjsargent(at)gmail(dot)com> writes:
> > On 04/13/2011 09:09 AM, Tom Lane wrote:
> >> Anish Kejariwal<anishkej(at)gmail(dot)com> writes:
> >>> (select store_id, avg(sales) sales
> >>> from store
> >>> where group_id in(select $1[i] from generate_subscripts($1, 1) g(i))
>
> >> Seems like a pretty brute-force way to deal with the array. Try
> >> where group_id = any($1)
> >> Not sure if it'll be a great deal faster, but it's at least easier to
> >> write.
>
> > Would adding a subservient function which actually uses the value of the
> > iteration (group_id) as a single parameter be of any use?
>
> Well, it'd be unlikely to solve the OP's actual complaint, which was
> performance. Hiding the semantics from the planner via a function
> (which generally looks like a black box to the planner) is even worse
> than hiding the semantics in a sub-SELECT, which I think is probably
> the root cause of the performance issue here.
>
> regards, tom lane
>
> --
> Sent via pgsql-sql mailing list (pgsql-sql(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-sql
>

In response to

Browse pgsql-sql by date

  From Date Subject
Next Message Volkmar Herbst GCI 2011-04-13 19:59:01 strange update behavior
Previous Message Charlie 2011-04-13 16:21:27 Re: [SQL] unnesting of array of different size explodes memory