From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Update functions and trigger functions by clicking |
Date: | 2011-05-31 10:44:26 |
Message-ID: | BANLkTikCz8HePO2L_jzGaSviFRysqqQe=Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Mon, May 30, 2011 at 1:58 AM, Vinicius Santos
<vinicius(dot)santos(dot)lista(at)gmail(dot)com> wrote:
>>>> in an object type independent way - ie. in pgObject for example. Not
>>>> sure how feasible that is though...
>
> Hello,
>
> It could take a look at my patch?
>
> I thought of other ways to implement, but I ended up with this.
Hi,
That seems pretty simple, but I think it misses one of the big issues
- avoiding pushing the refresh down the entire tree. As an example,
consider what happens if you click on a schema. As the code stands, it
looks like it'll cause not only the schema to be refreshed, but all of
the sub-objects that are currently populated on the tree. That could
make that click very expensive.
I think we need to find a way to ensure that the refresh is
constrained to the appropriate subset of objects - for a table, that
will probably include some of the sub-objects (eg. columns), for a
schema, just the schema itself.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2011-05-31 12:01:09 | pgAdmin III commit: Remove some empty dependents lines added by the sep |
Previous Message | Ashesh Vashi | 2011-05-31 09:57:05 | Re: PATCH: Using wxDatePickerCtrl instead of wxCalendarBox |