| From: | Greg Stark <gsstark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PGC_S_DEFAULT is inadequate |
| Date: | 2011-05-11 14:22:31 |
| Message-ID: | BANLkTik1Qqjs+hAKbCmXN191vBEMwSaMdA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 11, 2011 at 3:20 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> So this is fine if the
> current value was from the file or was the boot_val, but if we'd
> overridden the boot value with a "replacement" default value using
> PGC_S_DEFAULT, that code would cause the value to revert to the boot_val
> not the replacement value. Not desirable.
Doesn't this mean if you had a setting of timezone in your config file
and remove it and reload you'll get a different value than you would
have if you had actually booted without the line originally?
> My conclusion about all this is that we really need to invent another
> GucSource value falling between PGC_S_DEFAULT and PGC_S_ENV_VAR, called
> perhaps PGC_S_DYNAMIC_DEFAULT
LGTM
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-05-11 14:22:49 | Re: the big picture for index-only scans |
| Previous Message | Tom Lane | 2011-05-11 14:22:01 | Re: Re: 4.1beta1: ANYARRAY disallowed for DOMAIN types which happen to be arrays |