From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_upgrade and PGPORT |
Date: | 2011-05-12 13:42:08 |
Message-ID: | BANLkTi=hTHUV7MP+Rx57-ta9X9Sqh_gFPw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 12, 2011 at 1:22 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On ons, 2011-05-11 at 18:36 -0400, Bruce Momjian wrote:
>> Robert Haas wrote:
>> > On Wed, May 11, 2011 at 2:18 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> > > Or you could just "unsetenv" instead of complaining.
>> >
>> > +1 for that.
>>
>> OK, the attached patch does this, but allows PGCLIENTENCODING to be
>> passed in. The new output looks like:
>>
>> Performing Consistency Checks
>> -----------------------------
>> ignoring libpq environment variable PGPORT
>
> I haven't tried it, but I suppose option.c will now make use of PGPORT
> and then later you get that message that it was ignored?
Either way, it hardly seems necessary to emit a log message stating
that you are unsetting an environment variable.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-05-12 13:55:09 | Re: Infinity bsearch crash on Windows |
Previous Message | Albe Laurenz | 2011-05-12 12:33:24 | Uninitialized SSL values? (was: Fix for bug in ldapServiceLookup in libpq) |