| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Susanne Ebrecht <susanne(at)2ndquadrant(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FDW table hints |
| Date: | 2011-05-05 17:26:09 |
| Message-ID: | BANLkTi=BzJzZJZKKQ1mrQzgOLC+21xOTww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 5, 2011 at 19:22, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Since I brought it up - a patch along this line?
>
> Please don't capitalize "foreign table" there.
Yeah, I was a bit split about that myself. Will change.
> Also, I think an "else" before the other ereport would make the code
> clearer, even though it's not strictly necessary.
Agreed.
Unless someone objects, I'll go put that in later tonight. (along with
a comment on why there are two different msgs)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-05-05 17:28:50 | Re: Patch to improve style of generate_history.pl perl script |
| Previous Message | Tom Lane | 2011-05-05 17:22:18 | Re: FDW table hints |