Re: BUG #6041: Unlogged table was created bad in slave node

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Emanuel <postgres(dot)arg(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #6041: Unlogged table was created bad in slave node
Date: 2011-06-07 18:05:10
Message-ID: BANLkTi=2ewL63njHx7mth1tV6_NYimAR9A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Jun 7, 2011 at 11:50 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Patch along these lines attached.
>
> Frankly, I find this quite ugly, and much prefer the general approach of
> your previous patch in <BANLkTim433vF5HWjbJ0FSWm_-xA8DDaGNg(at)mail(dot)gmail(dot)com>.
>
> However, I don't like where you put the execution-time test there.  I'd
> put it in ExecOpenScanRelation instead, so that it covers both seqscan
> and indexscan accesses.

Ah, OK. I was wondering if there was a better place. I'll do it that
way, then.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Anton Dedov 2011-06-07 18:15:27 Re: ON DELETE CASCADE with multiple paths in PostgreSQL 9.x
Previous Message Andres Freund 2011-06-07 17:42:46 Re: BUG #6041: Unlogged table was created bad in slave node

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2011-06-07 18:06:32 Re: reducing the overhead of frequent table locks - now, with WIP patch
Previous Message Heikki Linnakangas 2011-06-07 18:00:10 Re: SIREAD lock versus ACCESS EXCLUSIVE lock