From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Steve Singer <ssinger_pg(at)sympatico(dot)ca> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: patch for 9.2: enhanced errors |
Date: | 2011-06-21 21:47:12 |
Message-ID: | BANLkTi=2dfJ-4J7wudQXwPqXt3JkwOPE8A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2011/6/21 Steve Singer <ssinger_pg(at)sympatico(dot)ca>:
> On 11-06-20 03:44 PM, Pavel Stehule wrote:
>
> Hello
>
> You need to update config.sgml at the same time you update this format.
> You need to append a "," after application name but before constraintName.
> As it stands the CSV log has something like:
> .....nbtinsert.c:433","psql""a_pkey","public","a","a"
>
> fixed
>
>
> The CSV log seems fine now.
>
>
>
> nbtinsert.c
>
> pg_get_indrelation is named differently than everything else in this file
> (ie _bt...). My guess is that this function belongs somewhere else but I
> don't know the code well enough to say where you should move it too.
>
> I renamed this function to IndexRelationGetParentRelation and muved to
> relcache.c
>
>
> Thanks, it looks less out of place there than it did in nbtinsert.c
>
> I don't call a quote_identifier on only data error properties like
> table_name or schema_name (but I am open to arguments for it or
> against it). The quote_identifier is used for column names, because
> there should be a more names and comma should be used inside name -
> and this is consistent with pg_get_indexdef_columns.
>
> Regards
>
>
> Okay.
>
>
>
> Pavel Stehule
>
>
> I'm going to mark this as ready for a committer.
>
Thank you very much
Regards
Pavel Stehule
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Alexey Klyukin | 2011-06-21 21:50:23 | Re: Identifying no-op length coercions |
Previous Message | Steve Singer | 2011-06-21 21:20:01 | Re: Online base backup from the hot-standby |