From: | Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}. |
Date: | 2011-05-28 07:05:17 |
Message-ID: | BANLkTi=0zF6DFeKCQyAJMX=DV3uo5coQfQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
2011/5/28 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
> Excerpts from Cédric Villemain's message of vie may 27 18:37:05 -0400 2011:
>> 2011/4/21 Robert Haas <rhaas(at)postgresql(dot)org>:
>
>> > Modified Files
>> > --------------
>> > doc/src/sgml/ref/alter_table.sgml | 26 +++
>> > src/backend/commands/tablecmds.c | 277 +++++++++++++++++++++++++++--
>>
>> I noticed 2 warnings on unused variables from gcc in tablecmds.c
>> The attached patch fix that by removing those 2 variables.
>
> My compiler wasn't complaining, but since the variable is clearly unused
> I went ahead and pushed this. Thanks
I have a recent gcc wich probably help here:
gcc-4.6.real (Debian 4.6.0-7) 4.6.1 20110507 (prerelease)
>
> --
> Álvaro Herrera <alvherre(at)commandprompt(dot)com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
>
--
Cédric Villemain 2ndQuadrant
http://2ndQuadrant.fr/ PostgreSQL : Expertise, Formation et Support
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-05-28 16:38:28 | pgsql: Fix null-dereference crash in parse_xml_decl(). |
Previous Message | Alvaro Herrera | 2011-05-28 01:53:52 | Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}. |
From | Date | Subject | |
---|---|---|---|
Next Message | nil nil | 2011-05-28 08:39:53 | patch integration |
Previous Message | tomas | 2011-05-28 06:26:53 | Re: storing TZ along timestamps |