From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pipe_read_line for reading arbitrary strings |
Date: | 2024-03-06 10:49:00 |
Message-ID: | BAFF9C8F-0F7A-440F-AFBC-B0CECA8AB48D@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 6 Mar 2024, at 11:46, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2024-Mar-06, Daniel Gustafsson wrote:
>
>> Good catch, that's an incorrect copy/paste, it should use ERRCODE_NO_DATA. I'm
>> not convinced that a function to read from a pipe should consider not reading
>> anything successful by default, output is sort expected here. We could add a
>> flag parameter to use for signalling that no data is fine though as per the
>> attached (as of yet untested) diff?
>
> I think adding dead code is not a great plan, particularly if it's hairy
> enough that we need to very carefully dissect what happens in error
> cases. IMO if and when somebody has a need for an empty return string
> being acceptable, they can add it then.
I agree with that, there are no callers today and I can't imagine one off the
cuff. The change to use the appropriate errcode still applies though.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2024-03-06 10:50:51 | Re: Adding deprecation notices to pgcrypto documentation |
Previous Message | Alvaro Herrera | 2024-03-06 10:46:29 | Re: pipe_read_line for reading arbitrary strings |