| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [doc] fix a potential grammer mistake |
| Date: | 2022-08-03 08:23:49 |
| Message-ID: | BAD0CAB0-0AAF-415A-B8AE-AD774E4F0784@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Aug 2022, at 10:10, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>
> I think in the following sentence, were should be replaced with have,
> what do you think?
>
> ```
> /*
> - * We were just issued a SAVEPOINT inside a
> transaction block.
> + * We have just issued a SAVEPOINT inside a
> transaction block.
> * Start a subtransaction. (DefineSavepoint already did
> * PushTransaction, so as to have someplace to
> put the SUBBEGIN
> * state.)
> ```
I'm not so sure. If I read this right the intent of the sentence is to convey
that the user has issued a SAVEPOINT to the backend, not the backend itself. I
think the current wording is the correct one.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erikjan Rijkers | 2022-08-03 08:27:42 | Re: [doc] fix a potential grammer mistake |
| Previous Message | Kyotaro Horiguchi | 2022-08-03 08:15:17 | Re: Race between KeepFileRestoredFromArchive() and restartpoint |