Re: Granting SET and ALTER SYSTE privileges for GUCs

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs
Date: 2021-12-13 20:58:25
Message-ID: BA6C2DC4-A169-4239-B7E2-B4F73EA908E3@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Dec 13, 2021, at 12:56 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> This patch had bit-rotted slightly, and I was attempting to remedy it.

I have that already, and getting ready to post. Give me a few minutes and I'll repost.

> However, I got a failure running the TAP tests because of this change:
>
>
> diff --git a/src/test/modules/test_pg_dump/t/001_base.pl
> b/src/test/modules/test_pg_dump/t/001_base.pl
> index 16f7610883..7fbf2d871b 100644
> --- a/src/test/modules/test_pg_dump/t/001_base.pl
> +++ b/src/test/modules/test_pg_dump/t/001_base.pl
> @@ -9,7 +9,12 @@ use PostgreSQL::Test::Cluster;
> use PostgreSQL::Test::Utils;
> use Test::More;
>
> -my $tempdir = PostgreSQL::Test::Utils::tempdir;
> +# my $tempdir = PostgreSQL::Test::Utils::tempdir;
> +my $tempbase = '/tmp/test_pg_dump';
> +my $subdir = 0;
> +$subdir++ while (-e "$tempbase/$subdir");
> +my $tempdir = "$tempbase/$subdir";
> +system("mkdir $tempdir");
>
>
>
> What's going on here?

Yeah, I hit that, too. That was an accidentally committed bit of local testing. Please ignore it for now.


Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-12-13 21:05:08 Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce)
Previous Message Andrew Dunstan 2021-12-13 20:56:34 Re: Granting SET and ALTER SYSTE privileges for GUCs