| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: docs: clarify ALTER TABLE behavior on partitioned tables |
| Date: | 2026-01-26 07:20:16 |
| Message-ID: | BA4C2371-C1E1-4E06-8719-7AED9B01EFF9@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jan 26, 2026, at 13:38, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> On Sunday, January 25, 2026, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> How about this:
> ```
> <para>
> When applied to a partitioned table to rename columns or constraints,
> the corresponding partition columns and constraints are renamed
> implicitly. <literal>ONLY</literal> is not allowed, and the command
> cannot be used on individual partitions. When the rename target is the
> table name, only the named table is renamed.
> </para>
> ```
>
> …are renamed implicitly, ONLY is not allowed, and the command cannot…(and drop the mention of table renaming).
>
> Or:
>
> “When applied to a partitioned table’s name only the parent is changed, partitions must be renamed separately. However, column or constraint renaming must be done on the parent without ONLY, the corresponding partition columns or constraints will be renamed implicitly.”
>
> I find the repeated use of “table” “name(d)” and “rename(d)” in one sentence worth avoiding.
Looks good. I just did a couple of tiny tweaks:
* Added a comma between “table’s name” and “only”: “when applied to a partitioned table’s name, only the parent …”
* Replaced “however” with “in contrast”.
PFA v8.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-docs-clarify-ALTER-TABLE-behavior-on-partitioned-.patch | application/octet-stream | 33.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-01-26 07:34:40 | Re: Adding REPACK [concurrently] |
| Previous Message | Chao Li | 2026-01-26 07:10:03 | Re: tablecmds: reject CLUSTER ON for partitioned tables earlier |