| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Greg Sabino Mullane" <htamfids(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: make MaxBackends available in _PG_init |
| Date: | 2021-08-16 04:02:16 |
| Message-ID: | B7E20C65-D0AB-47B2-BC43-A831601711A2@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/15/21, 1:05 AM, "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com> wrote:
> I don't think calling function GetMaxBackends() in the for loop is a good idea.
> How about use a temp variable to save the return value of function GetMaxBackends() ?
I did this in v4. There may be a couple of remaining places that call
GetMaxBackends() several times, but the function should be relatively
inexpensive.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Disallow-external-access-to-MaxBackends.patch | application/octet-stream | 30.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Soumyadeep Chakraborty | 2021-08-16 04:21:14 | Re: Changes to recovery_min_apply_delay are ignored while waiting for delay |
| Previous Message | Michael Paquier | 2021-08-16 03:52:55 | Failure of subscription tests with topminnow |