Re: "pivot aggregation" with a patched intarray

From: Marc Mamin <M(dot)Mamin(at)intershop(dot)de>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "pivot aggregation" with a patched intarray
Date: 2014-06-01 13:48:56
Message-ID: B6F6FD62F2624C4C9916AC0175D56D8828A81608@jenmbs01.ad.intershop.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>On Sat, May 31, 2014 at 12:31 AM, Marc Mamin <M(dot)Mamin(at)intershop(dot)de> wrote:
>> I have patched intarray with 3 additional functions in order to count[distinct] event IDs
>> into arrays, whereas the array position correspond to the integer values. (mimic column oriented storage)
>
>I didn't look at the feature itself, but here are some comments about
>the format of the patch:
>- Be careful the newlines on the file you posted use ¥r¥n, which is
>purely Windows stuff... This will generate unnecessary diffs with the
>source code

oops, will fix

>- Here are some guidelines about the code convention:
>http://www.postgresql.org/docs/devel/static/source.html
>- And here are a couple of rules to respect when submitting a patch:
>https://wiki.postgresql.org/wiki/Submitting_a_Patch
>Following those rules will make patch review as well as the life of
>reviewers easier.

thanks for your comments
I don't mean to suggests this directly as a patch,
I'm first interested to see if there are some interest
for such an aggregation type.

regards,

Marc Mamin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2014-06-01 14:40:06 teaching Var about NOT NULL
Previous Message Michael Paquier 2014-06-01 11:43:11 Re: "pivot aggregation" with a patched intarray