Re: backend/nodes cleanup: Move loop variables definitions into for statement

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: backend/nodes cleanup: Move loop variables definitions into for statement
Date: 2025-11-17 12:55:13
Message-ID: B5231580-8EA3-4FC3-9585-5BE5132D70D7@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Added to CF: https://commitfest.postgresql.org/patch/6227/

> On Nov 14, 2025, at 21:52, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> On Wed, Nov 12, 2025 at 4:00 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> Hi Hackers,
>
> While working on the other patch [1] that touched tbm_add_tuples() under src/backend/nodes, I moved a loop variable into for statement by the way as I knew Peter Eisentraut had done some efforts about that, see [2].
>
> However, Peter removed that change from the patch and he said that should belong to a separate cleanup patch. So I am following up and moving loop variables into for statements wherever possible under src/backend/nodes.
>
> [1] https://www.postgresql.org/message-id/flat/CAEoWx2m2E0xE8Kvbkv31ULh_E+5zph-WA_bEdv3UR9CLhw+3vg(at)mail(dot)gmail(dot)com
> [2] https://git.postgresql.org/cgit/postgresql.git/commit/?id=03fbb0814c5015ab79e670ab97bb6a3349269e4b
>
>
> Rebased to V2.
>
> Best regards,
> Chao Li (Evan)
> ---------------------
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
> <v2-0001-backend-nodes-cleanup-Move-loop-variables-definit.patch>

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2025-11-17 12:55:30 Re: [PATCH] jit: fix build with LLVM-21
Previous Message jian he 2025-11-17 12:53:35 Re: Extended Statistics set/restore/clear functions.