Re: Propose a new function - list_is_empty

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Propose a new function - list_is_empty
Date: 2022-08-17 08:23:16
Message-ID: B4E53BCB-74F7-4C87-8065-29924DC5AA62@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 17 Aug 2022, at 10:13, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>
> There are some places that add extra parenthesis like here
>
> ...
>
> Is it necessary to add that extra parenthesis?

It's not necessary unless needed for operator associativity, but also I don't
object to grouping with parenthesis as a visual aid for the person reading the
code. Going over the patch in more detail I might change my mind on some but I
don't object to the practice in general.

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-08-17 08:29:58 Re: Generalize ereport_startup_progress infrastructure
Previous Message Junwang Zhao 2022-08-17 08:13:45 Re: Propose a new function - list_is_empty