Re: On login trigger: take three

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Ivan Panchenko <wao(at)mail(dot)ru>
Cc: Andres Freund <andres(at)anarazel(dot)de>, a(dot)sokolov(at)postgrespro(dot)ru, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: Re: On login trigger: take three
Date: 2022-03-30 13:48:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 30 Mar 2022, at 13:21, Ivan Panchenko <wao(at)mail(dot)ru> wrote:
> Maybe side-effects is a bit too general? Emitting a log message, rejecting a
> login, setting some GUCs, etc are all side-effects too.
> Something like this:

I've reworded the docs close to what you suggested here.

> Also, please fix a typo in doc/src/sgml/ref/create_event_trigger.sgml :


> Regarding the trigger function example:
> It does not do anything if run on a standby. To show that it can do something on a standby to, I propose to move throwing the night exception to the beginning.

Good idea, done.

> Finally, let me propose to append to the regression test the following:

Also a good idea, done.

Daniel Gustafsson

Attachment Content-Type Size
v30-0002-Add-a-new-login-event-and-login-event-trigger-su.patch application/octet-stream 27.2 KB
v30-0001-Provide-a-GUC-for-temporarily-ignoring-event-tri.patch application/octet-stream 7.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-03-30 13:51:18 Re: On login trigger: take three
Previous Message Justin Pryzby 2022-03-30 13:44:02 Re: In-placre persistance change of a relation