| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "a(dot)lubennikova(at)postgrespro(dot)ru" <a(dot)lubennikova(at)postgrespro(dot)ru>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "matsumura(dot)ryo(at)fujitsu(dot)com" <matsumura(dot)ryo(at)fujitsu(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive status ".ready" files may be created too early |
| Date: | 2021-08-20 23:13:11 |
| Message-ID: | B3F7B5EA-25C5-4095-B6C1-DF04E7DBD48A@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/20/21, 4:00 PM, "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Attached is v14 which uses a separate spinlock.
This looks good to me.
I was looking at moving the function calls out of the spinlock region.
I don't think the functions are doing anything too expensive, and they
help clean up NotifySegmentsReadyForArchive() quite a bit, but I
understand why it might be against project policy to do something like
that. It would be easy enough to get rid of the helper functions if
that was concern.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | alvherre@alvh.no-ip.org | 2021-08-20 23:52:33 | Re: archive status ".ready" files may be created too early |
| Previous Message | alvherre@alvh.no-ip.org | 2021-08-20 23:00:14 | Re: archive status ".ready" files may be created too early |