Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows

From: "MauMau" <maumau307(at)gmail(dot)com>
To: "Kyotaro HORIGUCHI" <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: <thomas(dot)munro(at)enterprisedb(dot)com>, <pgsql-hackers(at)postgresql(dot)org>, <meskes(at)postgresql(dot)org>
Subject: Re: [bug fix] ECPG: freeing memory for pgtypes crashes on Windows
Date: 2018-03-25 13:15:52
Message-ID: B3BEB35436E3471095762969E2FCEDD6@tunaPC
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

From: Kyotaro HORIGUCHI
The objective of this patch looks reasonable and this doesn't
affect ecpg applications except for the problematic case that
happens only on Windows. So the points here are only the
documentation, the new function name and the how we should place
the new defintion.

I think this doesn't need more profound review so I'll mark this
Ready For Commit after confirming the amendment.

I'm sorry for my late reply. Last week I was off for a week.

And thank you for your review. All modifications are done.


Attachment Content-Type Size
pgtypes_freemem_v3.patch application/octet-stream 40.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2018-03-25 13:21:03 Re: Re: csv format for psql
Previous Message Michael Paquier 2018-03-25 12:26:07 Simplify final sync in pg_rewind's target folder and add --no-sync