Re: Bug in pg_get_aios()

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Bug in pg_get_aios()
Date: 2026-03-23 15:50:18
Message-ID: B22A310F-240B-4B2F-98B4-C273FC7DA60C@anarazel.de
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On March 23, 2026 4:44:21 AM EDT, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>On Mon, Mar 23, 2026 at 02:30:28PM +0800, Chao Li wrote:
>>> On Mar 23, 2026, at 14:23, cca5507 <cca5507(at)qq(dot)com> wrote:
>>> If I understand correctly, we want to set nulls[0] to true if owner_pid equals to 0:
>>
>> Indeed an obvious bug.
>
>Or the intention of the code could have been to allow a PID value of 0
>to be exposed, but I don't really buy it.

That certainly wasn't the intent :).

I suspect this is unreachable, we wait for ios before exiting, but of course that doesn't excuse broken code.

>Will fix, thanks for the report.

Thanks!

Andres

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2026-03-23 16:00:00 Re: Introduce XID age based replication slot invalidation
Previous Message Fujii Masao 2026-03-23 15:44:37 Re: Reduce log level of some logical decoding messages to DEBUG1