| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Joshua Brindle <joshua(dot)brindle(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Jeff Davis <pgsql(at)j-davis(dot)com>, Joe Conway <joe(at)crunchydata(dot)com> |
| Subject: | Re: New Object Access Type hooks |
| Date: | 2022-04-04 20:28:17 |
| Message-ID: | B188F52A-69B8-46E3-A32B-2FAFD9447FEF@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Apr 4, 2022, at 12:05 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
>> The "terminating connection" warning absolutely should get through,
>
> ... oh, no, that's not guaranteed at all, since it's sent from quickdie().
> So scratch that. Maybe we'd better add "could not send data to server"
> to the regex?
If it fails in pqsecure_raw_write(), you get either "server closed the connection unexpectedly" or "could not send data to server". Do we need to support pgtls_write() or pg_GSS_write(), which have different error messages? Can anybody run the tests with TLS or GSS enabled? I assume the test framework prevents this, but I didn't check too closely....
Is it possible that pgFlush will call pqSendSome which calls pqReadData before trying to write anything, and get back a "could not receive data from server" from pqsecure_raw_read()?
It's a bit hard to prove to myself which paths might be followed through this code. Thoughts?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-04-04 20:41:31 | Re: Mingw task for Cirrus CI |
| Previous Message | Robert Haas | 2022-04-04 20:17:59 | Re: Pluggable toaster |