| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-07-07 20:22:09 |
| Message-ID: | B148E25A-C11A-40CF-B9B9-D382ECD6253C@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Jul 2021, at 17:08, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> The patch was not applying on the head because of the recent commit
> "8aafb02616753f5c6c90bbc567636b73c0cbb9d4", attached patch which is
> rebased on HEAD.
I sort of like the visual cue of seeing ereport(ERROR .. since it makes it
clear it will break execution then and there, this will require a lookup for
anyone who don't know the function by heart. That being said, reducing
duplicated boilerplate has clear value and this reduce the risk of introducing
strings which are complicated to translate. On the whole I think this is a net
win, and the patch looks pretty good.
- DefElem *defel = (DefElem *) lfirst(option);
+ defel = (DefElem *) lfirst(option);
Any particular reason to include this in the patch?
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-07-07 20:24:06 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | David Christensen | 2021-07-07 19:56:46 | Re: [PATCH] expand the units that pg_size_pretty supports on output |