| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Jacob Champion <pchampion(at)vmware(dot)com> |
| Cc: | "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Enable SSL library detection via PQsslAttribute |
| Date: | 2022-03-28 20:33:57 |
| Message-ID: | B0A2E221-C7C9-4C4B-9705-C7B986D9E6B0@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 25 Mar 2022, at 23:45, Jacob Champion <pchampion(at)vmware(dot)com> wrote:
>
> On Fri, 2022-03-25 at 18:00 -0400, Tom Lane wrote:
>> Jacob Champion <pchampion(at)vmware(dot)com> writes:
>>> Do I need to merge my tiny test program into the libpq_pipeline tests?
>>
>> Doesn't seem worth the trouble to me, notably because you'd
>> then have to cope with non-SSL builds too.
>
> Fine by me.
>
> v5 moves the docs out of the Note, as requested by Daniel.
I went over this again and I think this version is ready for committer. Having
tried to add implement a new TLS library I would add a small comment on
PQsslAttributeNames() for this, reverse-engineering what to implement is hard
as it is without special cases easily identifiable. That can easily be done
when pushed, no need for a new version IMHO.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-03-28 20:38:47 | Re: refactoring basebackup.c (zstd workers) |
| Previous Message | Phil Krylov | 2022-03-28 20:33:37 | Re: jsonpath syntax extensions |