| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] WIP: Covering + unique indexes. |
| Date: | 2017-12-04 17:40:18 |
| Message-ID: | B06B9DC7-DBF6-4401-BE35-B7A2FFFEF2CD@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 30 нояб. 2017 г., в 23:07, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> написал(а):
>
> Seems like it was not a big deal of patching, I've fixed those bits (see attachment).
> I've done only simple tests as for now, but I'm planning to do better testing before next CF.
> Thanks for mentioning "heapallindexed", I'll use it too.
I've tested the patch with fixed amcheck (including "heapallindexed" feature), tests included bulk index creation, pgbenching and amcheck of index itself and WAL-replicated index.
Everything worked fine.
Spotted one more typo:
> Since 10.0 there is an optional INCLUDE clause
should be
> Since 11.0 there is an optional INCLUDE clause
I think that patch set (two patches + 1 amcheck diff) is ready for committer.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-12-04 17:42:24 | Re: Errands around AllocateDir() |
| Previous Message | Konstantin Knizhnik | 2017-12-04 17:18:42 | Re: [HACKERS] Secondary index access optimizations |