| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Why clearing the VM doesn't require registering vm buffer in wal record |
| Date: | 2026-06-29 07:46:57 |
| Message-ID: | B0228574-5AC9-4E3E-B42C-554629729A9F@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Jun 2026, at 15:41, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> I've done some
> mechanical checks on the 18 variant
A couple of minor things:
- The new t/012_vm_consistency.pl needs pg_visibility, but
src/bin/pg_combinebackup/Makefile doesn't declare
EXTRA_INSTALL=contrib/pg_visibility, so a standalone
"make -C src/bin/pg_combinebackup check" fails with "extension pg_visibility
is not available". (meson test and make check-world are fine, since they install
the whole tree) (for example see how src/bin/pg_amcheck pulls amcheck/pageinspect)
- A tiny wording nit: the comment on the retained visibilitymap_clear()
says it's kept "for backwards compatibility". Maybe spell out that it's kept for
ABI(prototype stability) on the back branches?
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-06-29 07:59:09 | Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint() |
| Previous Message | Jakub Wartak | 2026-06-29 07:42:49 | Re: Adding basic NUMA awareness |