Re: Cleanup explain_memoize function after test

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Cleanup explain_memoize function after test
Date: 2026-04-22 09:24:33
Message-ID: B01E4301-5120-4CCA-ABAA-DC5FEE6656ED@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Apr 22, 2026, at 14:49, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> Hi!
>
> I was doing some hacking today, when I noticed that the memoize
> regression test does not clean up the explain_memoize function after
> its end. I checked other regression tests and they tend to do it. So,
> I am not sure if there is a rule about `you should drop all objects
> that you create in regression test`, but if there is such a rule, PFA.
>
>
>
> --
> Best regards,
> Kirill Reshke
> <v1-0001-Cleanup-explain_memoize-after-resgression-test.patch>

Good catch.

You also need to update the corresponding out file, otherwise the test will fail. I have helped update the out file in v2, now “make check” passes with v2 applied.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Attachment Content-Type Size
v2-0001-Cleanup-explain_memoize-after-resgression-test.patch application/octet-stream 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2026-04-22 09:30:26 Re: Adding REPACK [concurrently]
Previous Message shveta malik 2026-04-22 09:23:21 Re: Parallel Apply