Re: pg_rewind copies

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: David Steele <david(at)pgmasters(dot)net>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_rewind copies
Date: 2021-11-09 13:11:51
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 25 Mar 2021, at 14:32, David Steele <david(at)pgmasters(dot)net> wrote:
> On 1/22/21 8:26 AM, Heikki Linnakangas wrote:
>> On 16/12/2020 00:08, Cary Huang wrote:
>>> The following review has been posted through the commitfest application:
>>> make installcheck-world: tested, passed
>>> Implements feature: tested, passed
>>> Spec compliant: tested, passed
>>> Documentation: not tested
>>> Hello
>>> The patch seems to do as described and the regression and tap tests are passing
>>> + /*
>>> + * A local source is not expected to change while we're rewinding, so check
>>> + * that we size of the file matches our earlier expectation.
>>> + */
>>> Is this a tyoo?
>> Yep, thanks! Attached is a new patch version, with that fixed and rebased. No other changes.
> Cary, does this patch look ready to commit? If so, please change the state in the CF entry to "Ready for Committer".

Reading the patch I think it definitely qualifies for RFC state. Heikki, do
you have plans to address till patch in the ongoing CF?

Daniel Gustafsson

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-11-09 13:31:33 Re: Skipping logical replication transactions on subscriber side
Previous Message Masahiko Sawada 2021-11-09 12:55:34 Re: Skipping logical replication transactions on subscriber side