| From: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow pg_read_all_stats to read pg_stat_progress_* |
| Date: | 2020-04-20 10:43:22 |
| Message-ID: | AED5F9D1-6EE7-4559-B261-39F1AD6D1695@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 16 апр. 2020 г., в 17:46, Magnus Hagander <magnus(at)hagander(dot)net> написал(а):
>
>
> If we do that, it may be better that we define "PGSTAT_VIEW_PRIV()" or
> something like and replace the all occurances of the idiomatic
> condition with it.
>
> You mean something like the attached?
>
> <allow_read_all_stats3.diff>
Is it correct that we use DEFAULT_ROLE_READ_ALL_STATS regardless of inheritance? I'm not familiar with what is inherited and what is not, so I think it's better to ask explicitly.
+#define HAS_PGSTAT_PERMISSIONS(role) (is_member_of_role(GetUserId(), DEFAULT_ROLE_READ_ALL_STATS) || has_privs_of_role(GetUserId(), role))
Besides this, the patch looks good to me.
Thanks!
Best regards, Andrey Borodin,
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2020-04-20 11:05:35 | Re: Allow pg_read_all_stats to read pg_stat_progress_* |
| Previous Message | Victor Yegorov | 2020-04-20 10:38:46 | Re: Poll: are people okay with function/operator table redesign? |