| From: | Jan Nidzwetzki <jan(at)planetscale(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Matt Blewitt <mble(at)planetscale(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Fix PITR pause bypass when initial XLOG_RUNNING_XACTS has subxid overflow |
| Date: | 2026-08-07 14:43:48 |
| Message-ID: | AD8F2737-DCD8-4B0D-8224-4B7EF32F29D2@planetscale.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
> On 16. Jun 2026, at 10:58, Jan Nidzwetzki <jan(at)planetscale(dot)com> wrote:
>
[...]
>
> The attached patch does that: when hot standby is not active at the
> recovery target (e.g., due to an incomplete snapshot), PostgreSQL will
> log a message and shut down instead of promoting silently. It mirrors
> how 'pause' is already downgraded to 'shutdown' when hot_standby is off.
> This lets the user choose a different recovery target or action. The
> patch also updates the documentation to clarify the behavior and adds a
> TAP test to verify the change.
Attached is a rebased version of the patch; cfbot reported that the
previous version no longer applies to master. v2 is a plain rebase with
no functional changes; the only other difference is a perltidy fix in
the TAP test.
The Commitfest entry is: https://commitfest.postgresql.org/patch/7026/
Any feedback on this approach would be welcome.
Best regards
Jan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Shut-down-instead-of-promoting-when-recovery-cann.patch | application/octet-stream | 9.2 KB |
| unknown_filename | text/plain | 51 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-08-07 15:13:09 | Re: Hot standby accepts connections (giving wrong results) before consistency after crash reset |
| Previous Message | vignesh C | 2026-08-07 14:21:32 | Re: Support EXCEPT for TABLES IN SCHEMA publications |