| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: datachecksums: handle invalid and dropped databases during enable |
| Date: | 2026-07-28 13:13:54 |
| Message-ID: | AC95ADBB-9D18-4A4E-9939-4154BCA56341@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 28 Jul 2026, at 12:01, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
> While testing the online enabling of datachecksums, I discovered some
> corner cases that can cause the background process to fail:
>
> * Invalid databases were only discovered when we tried to create
> checksums for them, when we could instead discover them before
> starting and fail early
> * Databases dropped while the checksum process was running also
> resulted in errors when it reached them and tried to build checksums
> for them. In this case we could continue safely: the database was
> dropped, there's no need to create checksums for it.
>
> I attached a patch that adds testcases for these and fixes the issues.
Thanks, I've reviewed and tested your patch and intend to push it along with
your other earlier patch shortly.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-07-28 13:15:30 | Re: FROM clause before SELECT |
| Previous Message | Greg Burd | 2026-07-28 13:10:54 | Don't use __builtin_setjmp on aarch64 MinGW/Windows |