| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Subject: | Re: LibreSSL and OpenSSL separation in libpq to support 1.1.1 deprecation |
| Date: | 2026-08-12 16:00:19 |
| Message-ID: | AC728D83-CFB1-4740-9980-5241415F7784@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 12 Aug 2026, at 13:24, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> I think it should be possible to have one file where the common routines
> that are identical for both libraries live (say be-secure-lossl.c for
> "libre/open" or whatever), and the corresponding be-secure-libressl.c
> and be-secure-openssl.c files only have the routines that differ between
> the two implementations. So the common code appears once and has to be
> patched just once, and we would only have differences where we must.
A scheme like that is certainly an option as well. There might also be parts
which could be extracted into be-secure-common.c on the grounds of not being
OpenSSL specific at all.
> Probably it's easiest to do this by having one .c file that's included
> by the other two, to avoid having to export the static variables and
> such.
I'm not a fan of #including a C file, and the move towards threading requires
us to clean up and remove such things anyways no?
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-08-12 16:16:20 | Re: Disallow outer-level and WHERE-clause aggregates in GRAPH_TABLE |
| Previous Message | Haibo Yan | 2026-08-12 15:58:50 | Re: [PATCH] Remove redundant ORDER BY from COUNT aggregates |