Re: Cluster::restart dumping logs when stop fails

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cluster::restart dumping logs when stop fails
Date: 2024-04-07 22:28:42
Message-ID: ABE3B99A-8CF3-4EDB-B70B-F5CB80BBA2AC@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 7 Apr 2024, at 18:51, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 7 Apr 2024, at 18:28, Andres Freund <andres(at)anarazel(dot)de> wrote:

>> I'm ok with printing path + some content or just the path.
>
> I think printing the last 512 bytes or so would be a good approach, I'll take
> care of it later tonight. That would be a backpatchable change IMHO.

In the end I opted for just printing the path to avoid introducing logic (at
this point in the cycle) for ensuring that a negative offset doesn't exceed the
filesize. Since it changes behavior I haven't backpatched it, but can do that
if we think it's more of a fix than a change (I think it can be argued either
way, I have no strong feelings).

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2024-04-07 22:34:37 Re: POC, WIP: OR-clause support for indexes
Previous Message Melanie Plageman 2024-04-07 22:26:31 Re: Use streaming read API in ANALYZE