| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Covering GiST indexes |
| Date: | 2019-01-29 17:45:33 |
| Message-ID: | AB8B1A5E-9AB3-43FE-8FA8-3E7E9FCF4D64@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks! Here's new version 8
> 29 янв. 2019 г., в 22:00, Andreas Karlsson <andreas(at)proxel(dot)se> написал(а):
>
> * I think it is worth writing a short comment when you create truncTupdesc about why this is done.
It resulted in not so short comment, but I think it is OK.
>
> * Very minor thing: the diff below is pointless churn on a line not touched by the patch.
>
> - values, isnull, true /* size is currently bogus */ );
> + values, isnull, true /* size is currently bogus */);
Fixed.
>
> * Another very minor thing: The diff below from gistFormTuple() should probably be consistent about brackets.
>
> + if (isnull[i])
> + compatt[i] = (Datum) 0;
> + else
> + {
> + compatt[i] = attdata[i];
> + }
Fixed.
Also, I've unified gist and r-tree syntax tests for INCLUDE.
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Covering-GiST-v8.patch | application/octet-stream | 30.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2019-01-29 18:43:10 | Re: Covering GiST indexes |
| Previous Message | Dmitry Belyavsky | 2019-01-29 17:43:07 | Ltree syntax improvement |