| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: refactoring comment.c |
| Date: | 2010-08-27 22:07:55 |
| Message-ID: | AANLkTinuHm-MgTc9QanGsRUL912kNC7L7Qbv9Up=9jpq@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 27, 2010 at 5:57 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I suppose this is unhappy because it things elog(ERROR) might
>> return?
>
> If I set these fields right in front of the elog(ERROR) the warnings
> go away for me. (Hopefully this observation will make up, to some
> extent, for my earlier brain fart.)
I set them right after the ERROR so that those statements needn't
actually be executed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2010-08-27 22:10:49 | Re: refactoring comment.c |
| Previous Message | Greg Smith | 2010-08-27 22:03:29 | Re: Performance Farm Release |