From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | little mistakes in HS/SR |
Date: | 2010-07-22 05:41:05 |
Message-ID: | AANLkTintWWMmmYzG6zyBKcoHt7mmU6XE3yDTP1YLPUn-@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
I found some little mistakes in HS/SR code and document.
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 9ae022a..db78b2b 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -2000,7 +2000,7 @@ SET ENABLE_SEQSCAN TO OFF;
<varname>max_standby_archive_delay</> applies when WAL data is
being read from WAL archive (and is therefore not current).
The default is 30 seconds. Units are milliseconds if not specified.
- A value of -1 allows the standby to wait forever for conflicting
+ A value of <literal>-1</> allows the standby to wait forever
for conflicting
queries to complete.
This parameter can only be set in the <filename>postgresql.conf</>
file or on the server command line.
@@ -2030,7 +2030,7 @@ SET ENABLE_SEQSCAN TO OFF;
<varname>max_standby_streaming_delay</> applies when WAL data is
being received via streaming replication.
The default is 30 seconds. Units are milliseconds if not specified.
- A value of -1 allows the standby to wait forever for conflicting
+ A value of <literal>-1</> allows the standby to wait forever
for conflicting
queries to complete.
This parameter can only be set in the <filename>postgresql.conf</>
file or on the server command line.
We should enclose -1 with <literal> tag.
diff --git a/src/backend/replication/walsender.c
b/src/backend/replication/walsender.c
index 0c4b217..53c2581 100644
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -93,6 +93,7 @@ static volatile sig_atomic_t ready_to_stop = false;
static void WalSndSigHupHandler(SIGNAL_ARGS);
static void WalSndShutdownHandler(SIGNAL_ARGS);
static void WalSndQuickDieHandler(SIGNAL_ARGS);
+static void WalSndLastCycleHandler(SIGNAL_ARGS);
We seems to have forgotten to add the declaration of WalSndLastCycleHandler().
I also attached the context-diff patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
fix_mistakes_hs_sr_v1.patch | application/octet-stream | 2.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2010-07-22 05:42:03 | Re: accentuated letters in text-search |
Previous Message | Jeff Davis | 2010-07-22 05:12:29 | Re: [9.1] pg_stat_get_backend_server_addr |