| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: sepgsql contrib module |
| Date: | 2011-01-24 02:56:34 |
| Message-ID: | AANLkTinnH9xH78j8K2HKYw9pio9CUPp2MWyQ5OCcdYSM@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> 2011/1/21 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
>> The attached patch is a revised version.
>
> I've committed this. Cleanup coming...
Yikes. On further examination, exec_object_restorecon() is pretty
bogus. Surely you need some calls to quote_literal_cstr() in there
someplace. And how about using getObjectDescriptionOids() for the
error message, instead of the entirely bogus construction that's there
now?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xiaobo Gu | 2011-01-24 03:09:19 | Re: 答复: [HACKERS] Is there a way to build PostgreSQL client libraries with MinGW |
| Previous Message | Stephen Frost | 2011-01-24 02:49:37 | Re: REVIEW: WIP: plpgsql - foreach in |