| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: pgAdmin III commit: Ensure the embedded version of OGL builds properly |
| Date: | 2011-02-17 08:50:46 |
| Message-ID: | AANLkTinkbX8QsKog+PL6V8siF=6A5P0jsE_QsGfMCa5Z@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Feb 17, 2011 at 2:57 AM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> This commit has eliminated the remaining OGL related warnings that I
> mentioned on the main phase 2 thread, that are described here:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159.
>
> I now build pgAdmin warning free on g++ 4.5.1.
>
> I incorrectly assumed that attributes were consistent between
> declaration and definition, as they apparently were for the poster of
> that bug report.
Oh, cool - I hadn't even considered that as an issue on *nix. I had it
in my head those macros only did anything on Windows.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2011-02-17 08:55:14 | pgAdmin III commit: Make style. |
| Previous Message | Peter Geoghegan | 2011-02-17 02:57:30 | Re: pgAdmin III commit: Ensure the embedded version of OGL builds properly |