frmStatus: Assertion on linux and Segment Fault on Solaris

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: frmStatus: Assertion on linux and Segment Fault on Solaris
Date: 2010-09-01 08:42:23
Message-ID: AANLkTineEYgmx_Hw=W94AUt701E5iLvQ+=dk1bLXEXAc@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

I found that - while fetching and displaying the log, we are assuming that -
all the columns will present at that point of time. (i.e. TimeStamp, Log
Level, Log Entry).
But, it may present or not.
i.e. If we do not have log_prefix_line does not contain '%t', than TimeStamp
column will not be present.
The following code suggests the same:
*void frmStatus::AddLogPane()*
*{*
* ...*
* else // Non-GPDB or non-CSV format log*
* {*
* if (logHasTimestamp)*
* logList->AddColumn(_("Timestamp"), 100);*
*
*
* if (logFormatKnown)*
* logList->AddColumn(_("Level"), 35);*
*
*
* logList->AddColumn(_("Log entry"), 800);*
* }*
* ...*
*}*
So, we need to put the parsed logs in particular column based on these
boolean values.
And, this was causing assert on linux and core dump on Solaris 10 sparc
machine.

Please find patches for the REL-1_10_PATCHES and REL-1_12_PATCHES.

*--**
**Thanks & Regards,**

**Ashesh Vashi**
**EnterpriseDB INDIA:* Enterprise Postgres Company<http://www.enterprisedb.com>

Attachment Content-Type Size
frmStatus_Log_Behaviour_REL-1_10.patch text/x-patch 3.2 KB
frmStatus_Log_Behaviour_REL-1_12.patch text/x-patch 3.2 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2010-09-01 10:09:30 Re: Serverlog
Previous Message Steffen Kuhn 2010-09-01 05:50:57 Serverlog